test(e2e): migrate OpenClaw skill CLI scenario - #5354
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a free-standing Vitest job ChangesOpenClaw skill CLI E2E Vitest job
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt |
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt |
Contributor
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27436103532
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27437481427
|
cv
marked this pull request as ready for review
June 12, 2026 21:03
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/e2e-scenarios/free-standing-jobs.env`:
- Around line 3-5: The CI summary is inaccurate because
tools/e2e-scenarios/free-standing-jobs.env still lists
credential-migration-vitest and gateway-guard-recovery in the allowed_jobs
variable; update allowed_jobs (or the PR summary) to reflect the actual
removals, and ensure free_standing_scenarios_csv and
free_standing_scenario_jobs_csv are consistent with allowed_jobs (check entries
like credential-migration and gateway-guard-recovery). Separately, diagnose the
regex-validation CI failure by reproducing the validator using the exact CI
validator error output (not this env) — inspect
tools/e2e-scenarios/workflow-boundary.mts for the MODULE_NOT_FOUND: yaml and run
the CI validator locally with its error log to pinpoint the failing regex
line/revision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 91760fcc-8e02-4f6f-bb1c-3dc7b18f3c02
📒 Files selected for processing (4)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/live/openclaw-skill-cli.test.tstest/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tstools/e2e-scenarios/free-standing-jobs.env
79 tasks
This was referenced Jun 16, 2026
wscurran
added
area: ci
wscurran
added
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
test/e2e/test-openclaw-skill-cli-e2e.shinto a focused live Vitest scenario while preserving the realinstall.sh/OpenShell sandbox boundary and direct in-sandbox OpenClaw skills CLI checks. Wires the migrated scenario into manual E2E Vitest dispatch asopenclaw-skill-cli-vitest.Related Issue
Refs #5098
Changes
test/e2e-scenario/live/openclaw-skill-cli.test.tsfor the install/list/info/check workspace skill roundtrip.openclaw-skill-cliin the free-standing Vitest scenario inventory.openclaw-skill-cli-vitestworkflow job and PR report fan-in.Type of Change
Verification
Ran and passed:
npx @biomejs/biome lint test/e2e-scenario/live/openclaw-skill-cli.test.ts test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tsnpx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tsNEMOCLAW_RUN_E2E_SCENARIOS=1 npx vitest run --project e2e-scenarios-live test/e2e-scenario/live/openclaw-skill-cli.test.ts --reporter=default(skips at missingNVIDIA_API_KEYgate; no sandbox mutation)npm run build:cli && npm run typecheck:clicd nemoclaw && npm install --ignore-scripts && npm run buildAttempted:
npx prek run --all-filesafter root + plugin install/build; static hooks and plugin tests passed, but the CLI test hook timed out in unrelated 5s tests:test/cli/snapshot-shields.test.tsandsrc/lib/onboard/web-search-flow.test.ts.npx prek run --all-filespassesnpm testpassesTests added or updated for new or changed behavior
No secrets, API keys, or credentials committed
Docs updated for user-facing behavior changes
npm run docsbuilds without warnings (doc changes only)Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Tests
Chores
Infrastructure